// License: GPL. See LICENSE file for details.
package org.openstreetmap.josm.data.validation.tests;
import static org.openstreetmap.josm.tools.I18n.tr;
import java.util.ArrayList;
import java.util.Arrays;
import java.util.Collections;
import java.util.List;
import org.openstreetmap.josm.data.osm.Node;
import org.openstreetmap.josm.data.osm.OsmPrimitive;
import org.openstreetmap.josm.data.osm.Relation;
import org.openstreetmap.josm.data.osm.RelationMember;
import org.openstreetmap.josm.data.osm.Way;
import org.openstreetmap.josm.data.validation.Severity;
import org.openstreetmap.josm.data.validation.Test;
import org.openstreetmap.josm.data.validation.TestError;
/**
* Checks if turnrestrictions are valid
* @since 3669
*/
public class TurnrestrictionTest extends Test {
protected static final int NO_VIA = 1801;
protected static final int NO_FROM = 1802;
protected static final int NO_TO = 1803;
protected static final int MORE_VIA = 1804;
protected static final int MORE_FROM = 1805;
protected static final int MORE_TO = 1806;
protected static final int UNKNOWN_ROLE = 1807;
protected static final int UNKNOWN_TYPE = 1808;
protected static final int FROM_VIA_NODE = 1809;
protected static final int TO_VIA_NODE = 1810;
protected static final int FROM_VIA_WAY = 1811;
protected static final int TO_VIA_WAY = 1812;
protected static final int MIX_VIA = 1813;
protected static final int UNCONNECTED_VIA = 1814;
protected static final int SUPERFLUOUS = 1815;
/**
* Constructs a new {@code TurnrestrictionTest}.
*/
public TurnrestrictionTest() {
super(tr("Turnrestrictions"), tr("This test checks if turnrestrictions are valid."));
}
@Override
public void visit(Relation r) {
if (!"restriction".equals(r.get("type")))
return;
Way fromWay = null;
Way toWay = null;
List<OsmPrimitive> via = new ArrayList<>();
boolean morefrom = false;
boolean moreto = false;
boolean morevia = false;
boolean mixvia = false;
/* find the "from", "via" and "to" elements */
for (RelationMember m : r.getMembers()) {
if (m.getMember().isIncomplete())
return;
List<OsmPrimitive> l = new ArrayList<>();
l.add(r);
l.add(m.getMember());
if (m.isWay()) {
Way w = m.getWay();
if (w.getNodesCount() < 2) {
continue;
}
switch (m.getRole()) {
case "from":
if (fromWay != null) {
morefrom = true;
} else {
fromWay = w;
}
break;
case "to":
if (toWay != null) {
moreto = true;
} else {
toWay = w;
}
break;
case "via":
if (!via.isEmpty() && via.get(0) instanceof Node) {
mixvia = true;
} else {
via.add(w);
}
break;
default:
errors.add(new TestError(this, Severity.WARNING, tr("Unknown role"), UNKNOWN_ROLE,
l, Collections.singletonList(m)));
}
} else if (m.isNode()) {
Node n = m.getNode();
if ("via".equals(m.getRole())) {
if (!via.isEmpty()) {
if (via.get(0) instanceof Node) {
morevia = true;
} else {
mixvia = true;
}
} else {
via.add(n);
}
} else {
errors.add(new TestError(this, Severity.WARNING, tr("Unknown role"), UNKNOWN_ROLE,
l, Collections.singletonList(m)));
}
} else {
errors.add(new TestError(this, Severity.WARNING, tr("Unknown member type"), UNKNOWN_TYPE,
l, Collections.singletonList(m)));
}
}
if (morefrom) {
errors.add(new TestError(this, Severity.ERROR, tr("More than one \"from\" way found"), MORE_FROM, r));
}
if (moreto) {
errors.add(new TestError(this, Severity.ERROR, tr("More than one \"to\" way found"), MORE_TO, r));
}
if (morevia) {
errors.add(new TestError(this, Severity.ERROR, tr("More than one \"via\" node found"), MORE_VIA, r));
}
if (mixvia) {
errors.add(new TestError(this, Severity.ERROR, tr("Cannot mix node and way for role \"via\""), MIX_VIA, r));
}
if (fromWay == null) {
errors.add(new TestError(this, Severity.ERROR, tr("No \"from\" way found"), NO_FROM, r));
return;
}
if (toWay == null) {
errors.add(new TestError(this, Severity.ERROR, tr("No \"to\" way found"), NO_TO, r));
return;
}
if (via.isEmpty()) {
errors.add(new TestError(this, Severity.ERROR, tr("No \"via\" node or way found"), NO_VIA, r));
return;
}
if (via.get(0) instanceof Node) {
final Node viaNode = (Node) via.get(0);
final Way viaPseudoWay = new Way();
viaPseudoWay.addNode(viaNode);
checkIfConnected(fromWay, viaPseudoWay,
tr("The \"from\" way does not start or end at a \"via\" node."), FROM_VIA_NODE);
if (toWay.isOneway() != 0 && viaNode.equals(toWay.lastNode(true))) {
errors.add(new TestError(this, Severity.WARNING, tr("Superfluous turnrestriction as \"to\" way is oneway"), SUPERFLUOUS, r));
return;
}
checkIfConnected(viaPseudoWay, toWay,
tr("The \"to\" way does not start or end at a \"via\" node."), TO_VIA_NODE);
} else {
// check if consecutive ways are connected: from/via[0], via[i-1]/via[i], via[last]/to
checkIfConnected(fromWay, (Way) via.get(0),
tr("The \"from\" and the first \"via\" way are not connected."), FROM_VIA_WAY);
if (via.size() > 1) {
for (int i = 1; i < via.size(); i++) {
Way previous = (Way) via.get(i - 1);
Way current = (Way) via.get(i);
checkIfConnected(previous, current,
tr("The \"via\" ways are not connected."), UNCONNECTED_VIA);
}
}
if (toWay.isOneway() != 0 && ((Way) via.get(via.size() - 1)).isFirstLastNode(toWay.lastNode(true))) {
errors.add(new TestError(this, Severity.WARNING, tr("Superfluous turnrestriction as \"to\" way is oneway"), SUPERFLUOUS, r));
return;
}
checkIfConnected((Way) via.get(via.size() - 1), toWay,
tr("The last \"via\" and the \"to\" way are not connected."), TO_VIA_WAY);
}
}
private void checkIfConnected(Way previous, Way current, String msg, int code) {
boolean c;
if (previous.isOneway() != 0 && current.isOneway() != 0) {
// both oneways: end/start node must be equal
c = previous.lastNode(true).equals(current.firstNode(true));
} else if (previous.isOneway() != 0) {
// previous way is oneway: end of previous must be start/end of current
c = current.isFirstLastNode(previous.lastNode(true));
} else if (current.isOneway() != 0) {
// current way is oneway: start of current must be start/end of previous
c = previous.isFirstLastNode(current.firstNode(true));
} else {
// otherwise: start/end of previous must be start/end of current
c = current.isFirstLastNode(previous.firstNode()) || current.isFirstLastNode(previous.lastNode());
}
if (!c) {
errors.add(new TestError(this, Severity.ERROR, msg, code, Arrays.asList(previous, current)));
}
}
}